debuginfo: Add a name for tuple fields in debuginfo so that they can be accessed in debuggers. #24351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
💯 |
michaelwoerister
force-pushed
the
named-tuple-fields
branch
from
8c72f5c to
03f9269
Compare
|
It's always the same with you, @michaelwoerister... |
|
Cool! Just to confirm, this couldn't be just |
|
@jakub- That's correct. I've tried using just the index but GDB's parser can't handle that. |
bors
added a commit
that referenced
this pull request
Apr 13, 2015
…chton
This PR makes `rustc` emit field names for tuple fields in DWARF. Formerly there was no way of directly accessing the fields of a tuple in GDB and LLDB since there is no C/C++ equivalent to this. Now, the debugger sees the name `__{field-index}` for tuple fields. So you can type for example `some_tuple_val.__2` to get the third tuple component.
When pretty printers are used (e.g. via `rust-gdb` or `rust-lldb`) these artificial field names will not clutter tuple rendering (which was the main motivation for not doing this in the past).
Solves #21948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
rustcemit field names for tuple fields in DWARF. Formerly there was no way of directly accessing the fields of a tuple in GDB and LLDB since there is no C/C++ equivalent to this. Now, the debugger sees the name__{field-index}for tuple fields. So you can type for examplesome_tuple_val.__2to get the third tuple component.When pretty printers are used (e.g. via
rust-gdborrust-lldb) these artificial field names will not clutter tuple rendering (which was the main motivation for not doing this in the past).Solves #21948.